Re: [PATCH 4/5] git send-email: ask less questions when --compose is used.

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 4, 2008, 23:54 UTC
Message-ID: <7vvdv3nj28.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1225815858-30617-5-git-send-email-madcoder@debian.org>

Pierre Habouzit <madcoder@debian.org> writes:

Show 11 quoted lines

> +	print C <<EOT;
> +From $tpl_sender # This line is ignored.
> +GIT: Lines beginning in "GIT: " will be removed.
> +GIT: Consider including an overall diffstat or table of contents
> +GIT: for the patch you are writing.
> +GIT:
> +GIT: Clear the body content if you don't wish to send a summary.
> +From: $tpl_sender
> +Subject: $tpl_subject
> +In-Reply-To: $tpl_reply_to
> +

Somebody already suggested this but I really think GIT: lines should be at the end and use '# ' prefix instead.

With the ability to give --cover-letter option to underlying format-patch do you still need this?

Show 7 quoted lines

> +	my $editor = $ENV{GIT_EDITOR} || Git::config(@repo, "core.editor") || $ENV{VISUAL} || $ENV{EDITOR} || "vi";
> +
> +	if ($annotate) {
> +		do_edit($compose_filename, @files);
> +	} else {
> +		do_edit($compose_filename);
> +	}

Don't we want to abort the whole process when the user kills the editor instead of normal exit (iow, do_edit() which is system() reports that the editor was killed)?