[PATCH 3/3] git send-email: turn --compose on when more than one patch.
- From
Pierre Habouzit <madcoder@debian.org>
- Date
- Oct 31, 2008, 12:36 UTC
- Message-ID
- <1225456609-694-4-git-send-email-madcoder@debian.org>
- In-Reply-To
- <1225456609-694-3-git-send-email-madcoder@debian.org>
Automatically turn --compose on when there is more than one patch, and that the output is a tty.
Do not print the list of files sent anymore in that case, as the list is shown in the summary editor.
Signed-off-by: Pierre Habouzit <madcoder@debian.org> --- git-send-email.perl | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl index 5c189a7..5cebb40 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -49,7 +49,7 @@ git send-email [options] <file | directory | rev-list > --subject <str> * Email "Subject:" --in-reply-to <str> * Email "In-Reply-To:" --annotate * Review each patch that will be sent in an editor. - --compose * Open an editor for introduction. + --[no-]compose * Open an editor for introduction. Sending: --envelope-sender <str> * Email envelope sender. @@ -237,7 +237,7 @@ my $rc = GetOptions("sender|from=s" => \$sender, "smtp-encryption=s" => \$smtp_encryption, "identity=s" => \$identity, "annotate" => \$annotate, - "compose" => \$compose, + "compose!" => \$compose, "quiet" => \$quiet, "cc-cmd=s" => \$cc_cmd, "suppress-from!" => \$suppress_from, @@ -409,7 +409,11 @@ if ($validate) { } if (@files) { - unless ($quiet) { + if (!defined($compose) && -t STDOUT) { + # turn $compose on if there is more than one file + $compose = $#files; + } + unless ($quiet || $compose) { print $_,"\n" for (@files); } } else {
-- 1.6.0.3.763.g0275.dirty