Re: [take 2] git send-email updates

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 11, 2008, 20:30 UTC
Message-ID: <7v4p2e0zus.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1226361242-2516-1-git-send-email-madcoder@debian.org>

Pierre Habouzit <madcoder@debian.org> writes:

Show 11 quoted lines

> The last patch is dropped for now (the automatic --compose stuff)
> because I'm not sure which option to add, and that I don't care enough
> about it to spend more time on it.
>
> I think I've incorporated most of the stuff people asked about in this
> series.
>
>  [PATCH 1/4] git send-email: make the message file name more specific.
>  [PATCH 2/4] git send-email: interpret unknown files as revision lists
>  [PATCH 3/4] git send-email: add --annotate option
>  [PATCH 4/4] git send-email: ask less questions when --compose is used.

Thanks.

It is somewhat unfortunate that an explicit --no-format-patch works exactly the same way as not giving the option at all. I would have expected that it would guess and warn if you did not give either, and it would not even guess (i.e. file is mbox, dir is maildir) and error out if there is a leftover option in @rev_list_opts if the user explicitly asked the command not act as a frontend to format patch.

I will queue the series in 'pu' because I suspect you would like a chance to amend out a "print foo" from the second commit ;-)