Re: [PATCH] provide advance warning of some future pack default changes

From: Nicolas Pitre <nico@cam.org>
Date: Dec 17, 2007, 21:45 UTC
Message-ID: <alpine.LFD.0.999999.0712171641460.8467@xanadu.home>
In-Reply-To: <7v3au16myj.fsf@gitster.siamese.dyndns.org>

On Mon, 17 Dec 2007, Junio C Hamano wrote:

Show 15 quoted lines

> This is mostly spilt milk under the bridge now, but I have to mildly
> disagree.
> 
> If we had core.usedeltabaseoffset instead of repack.usedeltabaseoffset,
> and made the format negotiation in fetch-pack protocol pay attention to
> that variable, Joel's coworker did not have to suffer if the repository
> explicitly asked OFS_DELTA not to be used.
> 
> Instead we unconditionally said "if you are downloading with the new
> client, we assume you would never be using older client to access that
> repository locally, if you did so, you are screwed."
> 
> IOW, I think e4fe4b8ef7cdde842a9e5e2594d0fba1367d9dd3 (let the GIT
> native protocol use offsets to delta base when possible) could have been
> a bit more careful in this respect.

Probably. But this can hardly be called a "corruption" since nothing was actually lost, rather an incompatibility problem.

If, on the other hand, the latest Git version wasn't able to read it either then this is a different matter entirely.

Nicolas