Re: [PATCH] provide advance warning of some future pack default changes

From: Nicolas Pitre <nico@cam.org>
Date: Dec 14, 2007, 22:34 UTC
Message-ID: <alpine.LFD.0.999999.0712141724260.8467@xanadu.home>
In-Reply-To: <20071214215206.GB7300@mail.oracle.com>

On Fri, 14 Dec 2007, Joel Becker wrote:

Show 15 quoted lines

> On Fri, Dec 14, 2007 at 08:38:51AM -0500, Nicolas Pitre wrote:
> > On Fri, 14 Dec 2007, Jakub Narebski wrote:
> > > Which means what? Local clone with shortcut (hardlinking and remotes)?
> > > Dumb protocols (http, ftp, rsync)?
> > 
> > Right, or simply shared repo over NFS or the like.
> > 
> > The 1.5.5 release notes will contain a note reminding people to set the 
> > corresponding config variables if they wish to retain the legacy 
> > behaviors.
> 
> 	We've seen that release notes are a poor way to communicate
> this.  What will happen to a 1.4.4 user when they try to access the
> repository?  Corruption, cryptic error message, or clean "this repo is
> not compatible" message?

There won't be any corruption.

In the best case there will be a message along "x is not supported by this version of Git -- please consider upgrading". In the worst case it'll say "x is bad".

But you know what? repositories with the change affecting 1.4.4 users are _already_ out there and no one complained recently. Anyone pushing changes over the native Git protocol is already using deltabaseoffset as the native protocol negociate that capability in its handshake, and these days we keep packs as is on the receiving side when they're large enough.

Nicolas