Re: [PATCH] provide advance warning of some future pack default changes

From: Jeff King <peff@peff.net>
Date: Dec 18, 2007, 19:30 UTC
Message-ID: <20071218193035.GA4583@sigill.intra.peff.net>
In-Reply-To: <Pine.LNX.4.64.0712181329340.23902@racer.site>

On Tue, Dec 18, 2007 at 01:30:49PM +0000, Johannes Schindelin wrote:

Show 7 quoted lines

> > Yes, it should be, but I think there will be a few user-visible fallouts
> > (like "--abbrev $foo" in scripts should now be "--abbrev-default $foo"
> > for safety).
> 
> But we are on our way to fix this, no?  IOW this warrants not a version 
> bump, but an extended feature freeze/bug fix period (like Junio suggested, 
> until January).

I think the resolution seems to be that we will now support "--abbrev foo", though we didn't in the past. Because the "foo" here is optional, the old "git log --abbrev HEAD" is ambiguous. In this case we'll see that "HEAD" isn't a number and DWIM. But that means a script trying to be unambiguous should use "git log --abbrev-default $foo" to make sure that "$foo" doesn't accidentally match as a number.

So there will be user-visible changes (though I don't expect them to be huge...there simply aren't that many variables with optional arguments).

-Peff