Re: [PATCH] provide advance warning of some future pack default changes

From: Nicolas Pitre <nico@cam.org>
Date: Dec 15, 2007, 02:23 UTC
Message-ID: <alpine.LFD.0.999999.0712142114400.8467@xanadu.home>
In-Reply-To: <20071215004230.GF7300@mail.oracle.com>

On Fri, 14 Dec 2007, Joel Becker wrote:

Show 21 quoted lines

> On Fri, Dec 14, 2007 at 05:46:14PM -0500, Nicolas Pitre wrote:
> > On Fri, 14 Dec 2007, Joel Becker wrote:
> > 
> > > On Fri, Dec 14, 2007 at 05:34:49PM -0500, Nicolas Pitre wrote:
> > > > But you know what? repositories with the change affecting 1.4.4 users 
> > > > are _already_ out there and no one complained recently.  Anyone pushing 
> > > 
> > > 	I did, as did people I work with.  It's on git-list, even.  I'm
> > > pretty sure it corrupted too.
> > 
> > Could you please give me a reference to such message, so to verify that 
> > we're actually talking about the same thing?
> 
> 	The relevant message is:
> 
> Message-ID: <7vveaindgp.fsf@gitster.siamese.dyndns.org>
> 
> See the paragraphs at the bottom.  The thread, started by me, begins
> with:
> 
> Message-ID: <20070910205429.GE27837@tasint.org>

OK. From those emails Junio forwarded to me, I don't see any case for actual _corruptions_. Git does indeed refuse to work with unknown pack index or unknown objects in a pack. Really old versions were not overly clueful as to why they refused to work, but they should never corrupt a pack which, for all purposes, is always read-only anyway.

Nicolas