Re: gitk patch collection pull request

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Oct 20, 2007, 04:51 UTC
Message-ID: <alpine.LFD.0.999.0710192149020.3794@woody.linux-foundation.org>
In-Reply-To: <18201.34779.27836.531742@cargo.ozlabs.ibm.com>

On Sat, 20 Oct 2007, Paul Mackerras wrote:

> 
> Do you mean that when you have a file limit, the diff window should
> just show the diffs for those files, not any other files the commit
> might have modified?

Yes. The same way "git log -p" works by default.

With perhaps a checkbox to toggle the "--full-diff" behaviour.

> That would be easy enough to implement in gitk.

Well, the "--merged" case is slightly trickier, since git will figure out the pathnames on its own (it limits pathnames to the intersection of the names you give one the command line *and* the list of unmerged files, ie the "filter" becomes "git ls-files -u [pathspec]".

But goodie. I look forward to it ;)

		Linus