Re: gitk patch collection pull request
- From
Paul Mackerras <paulus@samba.org>
- Date
- Oct 20, 2007, 11:46 UTC
- Message-ID
- <18201.60047.898077.579869@cargo.ozlabs.ibm.com>
- In-Reply-To
- <531A500E-667F-413C-BD20-D23DC817EB72@steelskies.com>
Jonathan del Strother writes:
> In my defense, most of that file is space indented, and the places
Only the lines that are indented 1 level start with spaces. Any line that is indented 2 or more levels should start with a tab.
> that are tab indented are generally totally broken unless you have an > 8 char tab width.
So set your tabs to 8 spaces when looking at it. :)
> It seems to have the whole 'tabs for code > indentation, with space for alignment' rule back-to-front.
I don't recall signing up to that rule. :) I use 4-column indentation and 8-column tabs, and my editor (emacs) handles it all automatically for me.
Paul.