git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: gitk patch collection pull request

From
Paul Mackerras <paulus@samba.org>
Date
Oct 20, 2007, 11:46 UTC
Message-ID
<18201.60047.898077.579869@cargo.ozlabs.ibm.com>
In-Reply-To
<531A500E-667F-413C-BD20-D23DC817EB72@steelskies.com>
Jonathan del Strother writes:
> In my defense, most of that file is space indented, and the places  

Only the lines that are indented 1 level start with spaces. Any line that is indented 2 or more levels should start with a tab.

> that are tab indented are generally totally broken unless you have an  
> 8 char tab width.
So set your tabs to 8 spaces when looking at it. :)
> It seems to have the whole 'tabs for code  
> indentation, with space for alignment' rule back-to-front.

I don't recall signing up to that rule. :) I use 4-column indentation and 8-column tabs, and my editor (emacs) handles it all automatically for me.

Paul.
Previous: Jonathan del StrotherNext: Jonathan del Strother
Message 9 of 25 in “gitk patch collection pull request”
  1. Shawn O. PearceOct 19, 2007
  2. gitk: Do not pick up file names of "copy from" linesJohannes Sixt, Oct 19, 2007
  3. Shawn O. PearceOct 19, 2007
  4. Johannes SixtOct 19, 2007
  5. Shawn O. PearceOct 19, 2007
  6. Paul MackerrasOct 19, 2007
  7. Shawn O. PearceOct 20, 2007
  8. Jonathan del StrotherOct 20, 2007
  9. Paul MackerrasOct 20, 2007
  10. Jonathan del StrotherOct 20, 2007
  11. Jan HudecOct 20, 2007
  12. gitk: fix in procedure drawcommitsMichele Ballabio, Oct 19, 2007
  13. Paul MackerrasOct 20, 2007
  14. Michele BallabioOct 20, 2007
  15. Jan HudecOct 20, 2007
  16. Paul MackerrasOct 21, 2007
  17. Rocco RutteOct 21, 2007
  18. Linus TorvaldsOct 19, 2007
  19. Paul MackerrasOct 20, 2007
  20. Linus TorvaldsOct 20, 2007
  21. Paul MackerrasOct 23, 2007
  22. Linus TorvaldsOct 23, 2007
  23. Paul MackerrasOct 23, 2007
  24. Linus TorvaldsOct 23, 2007
  25. Paul MackerrasOct 24, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.