git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: gitk patch collection pull request

From
Paul Mackerras <paulus@samba.org>
Date
Oct 19, 2007, 11:05 UTC
Message-ID
<18200.36704.936554.220173@cargo.ozlabs.ibm.com>
In-Reply-To
<20071019052823.GI14735@spearce.org>
Shawn O. Pearce writes:
Show 7 quoted lines
> The following changes since commit 719c2b9d926bf2be4879015e3620d27d32f007b6:
>   Paul Mackerras (1):
>         gitk: Fix bug causing undefined variable error when cherry-picking
> 
> are available in the git repository at:
> 
>   git://repo.or.cz:/git/spearce.git gitk
OK, but ...
> Jonathan del Strother (2):
>       gitk: Added support for OS X mouse wheel
>       Fixing gitk indentation

This one is bogus. Firstly, it doesn't have "gitk:" at the start of the headline (and "Fixing" should be "Fix"). Secondly, the actual change itself is bogus. It changes an initial tab to 8 spaces on each of 4 lines. I like it the way it is - and if he wanted to change it, he should have changed it throughout the file, not just on 4 lines. So that change is rejected.

The other changes are OK. If you could re-do your tree without 0d6df4de (and possible change "Added" to "Add" in e1b5683c while you're at it), I'll do the pull.

Paul.
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 6 of 25 in “gitk patch collection pull request”
  1. Shawn O. PearceOct 19, 2007
  2. gitk: Do not pick up file names of "copy from" linesJohannes Sixt, Oct 19, 2007
  3. Shawn O. PearceOct 19, 2007
  4. Johannes SixtOct 19, 2007
  5. Shawn O. PearceOct 19, 2007
  6. Paul MackerrasOct 19, 2007
  7. Shawn O. PearceOct 20, 2007
  8. Jonathan del StrotherOct 20, 2007
  9. Paul MackerrasOct 20, 2007
  10. Jonathan del StrotherOct 20, 2007
  11. Jan HudecOct 20, 2007
  12. gitk: fix in procedure drawcommitsMichele Ballabio, Oct 19, 2007
  13. Paul MackerrasOct 20, 2007
  14. Michele BallabioOct 20, 2007
  15. Jan HudecOct 20, 2007
  16. Paul MackerrasOct 21, 2007
  17. Rocco RutteOct 21, 2007
  18. Linus TorvaldsOct 19, 2007
  19. Paul MackerrasOct 20, 2007
  20. Linus TorvaldsOct 20, 2007
  21. Paul MackerrasOct 23, 2007
  22. Linus TorvaldsOct 23, 2007
  23. Paul MackerrasOct 23, 2007
  24. Linus TorvaldsOct 23, 2007
  25. Paul MackerrasOct 24, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.