Re: [PATCH-resent] gitk: fix in procedure drawcommits

From: Paul Mackerras <paulus@samba.org>
Date: Oct 21, 2007, 03:01 UTC
Message-ID: <18202.49408.264600.839673@cargo.ozlabs.ibm.com>
In-Reply-To: <200710201802.48111.barra_cuda@katamail.com>

Michele Ballabio writes:

Show 5 quoted lines

> This commit (and many others) has two parents, but the two parents
> have the same hash. So gitk tries to unset the same variable twice,
> hence the error. At this point, the fix for gitk should be either to
> check if the parents have the same hash when reading the commit or
> avoiding to unset two times the same variable.

Actually, there is a commit like that in the kernel tree, and with this clue, I have managed to reproduce the problem on the kernel tree with the command

	gitk v2.6.12-rc2..13e652800d1644dfedcd0d59ac95ef0beb7f3165

I have just pushed out a fix to my gitk.git tree.

Paul.