Re: gitk patch collection pull request

From: Jonathan del Strother <maillist@steelskies.com>
Date: Oct 20, 2007, 13:00 UTC
Message-ID: <B3349B61-995B-42D0-B777-CEA618943848@steelskies.com>
In-Reply-To: <18201.60047.898077.579869@cargo.ozlabs.ibm.com>

On 20 Oct 2007, at 12:46, Paul Mackerras wrote:

Show 6 quoted lines

> Jonathan del Strother writes:
>
>> In my defense, most of that file is space indented, and the places
>
> Only the lines that are indented 1 level start with spaces.  Any line
> that is indented 2 or more levels should start with a tab.

Show 6 quoted lines

>> It seems to have the whole 'tabs for code
>> indentation, with space for alignment' rule back-to-front.
>
> I don't recall signing up to that rule. :)  I use 4-column indentation
> and 8-column tabs, and my editor (emacs) handles it all automatically
> for me.

Ugh... I don't usually get involved in tab/space wars, but I'm curious... why on earth would you choose this style? With space indentation you can make sure that everyone sees the indentation as it was intended. With tab indentation, you save space, add semantic meaning, and let people control how wide they want their indents to appear. This approach seems to take the worst parts of each and combine them. What's the benefit?

I appreciate I'm not going to convert you - this is an honest question.