Re: [PATCH v3 01/38] sequencer: avoid unnecessary curly braces
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 14, 2017, 17:57 UTC
- Message-ID
- <alpine.DEB.2.20.1701141856240.3469@virtualbox>
- In-Reply-To
- <xmqqk2a0ktxr.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Thu, 12 Jan 2017, Junio C Hamano wrote:
Show 21 quoted lines
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>
> >
> > - if (!commit->parents) {
> > + if (!commit->parents)
> > parent = NULL;
> > - }
> > else if (commit->parents->next) {
> > /* Reverting or cherry-picking a merge commit */
> > int cnt;
>
> The result becomes
>
> if (...)
> single statement;
> else if (...) {
> multiple;
> statements;
> }
>
> which is not quite an improvement. Yet, this used to be the coding style of Git, and your statement comes quite as a surprise to me.
Ciao, Johannes