Re: [PATCH 20/34] sequencer (rebase -i): copy commit notes at end
- From
Dennis Kaarsemaker <dennis@kaarsemaker.net>
- Date
- Sep 1, 2016, 07:20 UTC
- Message-ID
- <1472714431.4680.1.camel@kaarsemaker.net>
- In-Reply-To
- <7427d5a9e76264252540c72c5a70e71c3d470667.1472633606.git.johannes.schindelin@gmx.de>
On wo, 2016-08-31 at 10:55 +0200, Johannes Schindelin wrote:
Show 12 quoted lines
> + if (!stat(rebase_path_rewritten_list(), &st) &&
> + st.st_size > 0) {
> + struct child_process child = CHILD_PROCESS_INIT;
> +
> + child.in = open(rebase_path_rewritten_list(), O_RDONLY);
> + child.git_cmd = 1;
> + argv_array_push(&child.args, "notes");
> + argv_array_push(&child.args, "copy");
> + argv_array_push(&child.args, "--for-rewrite=rebase");
> + /* we don't care if this copying failed */
> + run_command(&child);
> + }I know this is a strict port of git-rebase--interactive.sh, but shouldn't we at least warn the user that the copy failed?
D.