Re: [PATCH 27/34] sequencer (rebase -i): differentiate between comments and 'noop'
- From
Dennis Kaarsemaker <dennis@kaarsemaker.net>
- Date
- Sep 1, 2016, 08:33 UTC
- Message-ID
- <1472718815.4680.21.camel@kaarsemaker.net>
- In-Reply-To
- <736bcb8e860c876e32e8f89f68b0b901abedc187.1472633606.git.johannes.schindelin@gmx.de>
On wo, 2016-08-31 at 10:56 +0200, Johannes Schindelin wrote:
Show 12 quoted lines
> diff --git a/sequencer.c b/sequencer.c
> index 51c2f76..4c902e5 100644
> --- a/sequencer.c
> +++ b/sequencer.c
> @@ -763,7 +763,8 @@ enum todo_command {
> TODO_SQUASH,
> TODO_EXEC,
> TODO_NOOP,
> - TODO_DROP
> + TODO_DROP,
> + TODO_COMMENT
> };(picking a random commit that touches this enum)
In a few places you now make comparisons like "< TODO_NOOP", so I think it would be good to have a comment near the definition of this enum that says that ordering matters and why, so people don't attempt to add a new TODO_FOOBAR at the end.
D.