Re: [PATCH 07/34] sequencer (rebase -i): add support for the 'fixup' and 'squash' commands

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 2, 2016, 07:13 UTC
Message-ID: <alpine.DEB.2.20.1609012009070.129229@virtualbox>
In-Reply-To: <1472746749.4680.33.camel@kaarsemaker.net>

Hi Dennis,

On Thu, 1 Sep 2016, Dennis Kaarsemaker wrote:

Show 11 quoted lines

> On do, 2016-09-01 at 17:17 +0200, Johannes Schindelin wrote:
>
> > And I see that the beautiful ordinal computation was given up in favor
> > of a lousy "#1", "#2", "#3", etc (it used to be "1st", "2nd", "3rd"
> > etc).
> > 
> > In any case, translation is not my main concern until v2.10.0, so I'll
> > take care of this after that release.
> 
> Hmm, not sure if I agree with that. I'd see it as a regression to lose
> the i18n there.

As Git for Windows does not ship with translations (for multiple reasons), it would not be a regression.

Having said that, I see that having a different text than the current rebase -i can be seen as a regression, so I changed that.

Thanks for the review! Dscho