Re: [PATCH v2 01/34] sequencer: support a new action: 'interactive rebase'
- From
Stephan Beyer <s-beyer@gmx.net>
- Date
- Dec 19, 2016, 21:27 UTC
- Message-ID
- <940cbdcc-e289-6be2-29fd-97c5e2549642@gmx.net>
- In-Reply-To
- <alpine.DEB.2.20.1612191515000.54750@virtualbox>
Hi Dscho,
Show 13 quoted lines
>> However, maintaining more than one directory (like "sequencer" for >> sequencer state and "rebase-merge" for rebase todo and log) can cause >> the necessity to be even more careful when hacking on sequencer... For >> example, the cleanup code must delete both of them, not only one of them. > > That is incorrect. It depends on the options which directory is used. And > it is that directory (and not both) that should be cleaned up in the end. > > Otherwise you run into a ton of pain e.g. when running a rebase -i with an > `exec git cherry-pick ...` line: all of a sudden, that little innocuous > line would simply destroy the state directory of the current rebase -i. > > That's a rather big no-no.
Ahh, I see, there seems to be a misunderstanding on my side about how you did it (I did not look into the other patches (obviously)).
Thanks for clarifying!
Best Stephan