Re: [PATCH v4] config: add conditional include
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 14, 2016, 15:53 UTC
- Message-ID
- <alpine.DEB.2.20.1607141750190.6426@virtualbox>
- In-Reply-To
- <20160714153311.2166-1-pclouds@gmail.com>
Hi Duy,
On Thu, 14 Jul 2016, Nguyễn Thái Ngọc Duy wrote:
> Helped-by: Jeff King <peff@peff.com> > Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
This commit message is quite a bit short on details. I still fail to see what use case this would benefit, and I already start to suspect that the change would open a can of worms that might not be desired.
> + ; include if $GIT_DIR is /path/to/foo/.git > + [include "gitdir:/path/to/foo/.git"] > + path = /path/to/foo.inc
I find this way to specify a conditional unintuitive. Reading "gitdir:/path/to/foo/.git" suggests to me that the Git dir is *re-set*, not that this is a condition.
I would have expected something like
[include "if-gitdir-is:/path/to/foo/.git"]
instead.
Ciao, Dscho