Re: [PATCH] config: add conditional include
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Jun 27, 2016, 16:32 UTC
- Message-ID
- <CACsJy8D6TxkMWJTUCeDd8tuMyTRXcvWdMw4VL3nO7jbLEgjE-A@mail.gmail.com>
- In-Reply-To
- <20160627162052.GA4532@sigill.intra.peff.net>
On Mon, Jun 27, 2016 at 6:20 PM, Jeff King <peff@peff.net> wrote:
Show 7 quoted lines
> You do allow distinguishing the suffix thing with "/" at the end in the > rule above, though. So between the two rules: > > - slash at the end is a shorthand for "/**" > > - no-slash at the beginning (i.e., a non-absolute path) is a shorthand > for "**/" at the beginning
Neither slash or "./" at the beginning...
> you should be able to specify anything.
...then yeah it looks pretty good. With the exception of "./" we can still have paths relative to where the the config file is. For $HOME/.gitconfig that eliminates the need for expanding "~" ($HOME/.config/git/config may still need it, unless we allow "../" too, but that complicates matching).
> I do agree that there's value in trying to make the rules consistent > with other parts of git, though. I don't know the corner cases of > gitignore and gitattributes well enough to compare off the top of my > head, though (though I suspect you do. :) ).
Naah the complication of .gitignore and .gitattributes have long exceeded my brain's capacity.
-- Duy