Re: [PATCH v4] config: add conditional include
- From
Jakub Narębski <jnareb@gmail.com>
- Date
- Jul 20, 2016, 16:39 UTC
- Message-ID
- <578FA931.4050708@gmail.com>
- In-Reply-To
- <20160716164747.GA24933@sigill.intra.peff.net>
W dniu 2016-07-16 o 18:47, Jeff King pisze:
Show 11 quoted lines
> Heh. Don't get me wrong, I do think there's room for digging ourselves a > deep hole with conditional includes, because anything dynamic opens up a > question of _when_ it is evaluated, and in what context. So any > condition should be something that we would consider static through the > whole run of the program. Looking at the "gitdir" is right on the > borderline of that, but I think it's OK, because we already have to > invalidate any cached config when we setup the gitdir, because > "$GIT_DIR/config" will have become a new source. > > So I agree it's something we need to be thoughtful about, but I think > this particular instance is useful and probably not going to bite us.
A question: we have a way to track where the value came from (tracking includes). Do we have a way to check where the value didn't came from, because for example error in the include condition?
-- Jakub Narębski