Re: [PATCH v4] config: add conditional include
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Aug 22, 2016, 12:43 UTC
- Message-ID
- <CACsJy8C30=-LGMYQJ6MO17L8Vv1q=iQGC=R8TDhC5qM1f5Lh5A@mail.gmail.com>
- In-Reply-To
- <5c131421-ae7f-8a37-76ab-0fd05cbe3530@gmail.com>
On Sun, Aug 21, 2016 at 4:08 AM, Jakub Narębski <jnareb@gmail.com> wrote:
Show 21 quoted lines
> W dniu 19.08.2016 o 15:54, Jeff King pisze: >> On Sat, Aug 13, 2016 at 03:40:59PM +0700, Duy Nguyen wrote: >> >>> Ping.. >> >> There was some discussion after v4. I think the open issues are: >> >> - the commit message is rather terse (it should describe motivation, >> and can refer to the docs for the "how") >> >> - the syntax might be more clear as: >> >> [include-if "gitdir:..."] >> >> or >> >> [include "gitdir-is:..."] > > Or > > [include "if-gitdir:..."]
I like this one. I can re-roll to address the first two bullet point, if the last one, the open question, will not become a blocker later on.
-- Duy