Re: [PATCH v4] config: add conditional include

From: Duy Nguyen <pclouds@gmail.com>
Date: Jul 16, 2016, 14:48 UTC
Message-ID: <CACsJy8AvxC-p9=no+tYBc80-MWfApQ_QBagk0x7NXJDG9D=ZRw@mail.gmail.com>
In-Reply-To: <alpine.DEB.2.20.1607161507250.28832@virtualbox>

On Sat, Jul 16, 2016 at 3:30 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

> As an alternative solution to your problem, you could of course avoid all
> conditional includes. Simply by adding the include.path settings
> explicitly to the configs that require them. Now, that would make reasoning
> and trouble-shooting simple, wouldn't it?

I can't. Repos can be created and destroyed often (it's in the process), and there are many of them. Using a wrong identity (among other incorrect config settings) is a serious problem and I cannot guarantee myself that I will never make a mistake, forgetting to include stuff on new clones.

Show 16 quoted lines

>> > I still fail to see what use case this would benefit,
>>
>> It allows you to group repos together. The first mail that started all
>> this [1] is one of the use cases: you may want to use one identity in
>> a group of repos, and another identity in some other. I want some
>> more, to use a private key one some repos and another private key on
>> some other. Some more settings may be shareable this way, like coding
>> style-related (trailing spaces or not...)
>>
>> [1] http://thread.gmane.org/gmane.comp.version-control.git/273811
>>
>> > and I already start to suspect that the change would open a can of worms that might not be desired.
>>
>> You can choose not to use it, I guess.
>
> Sadly, as the maintainer I am unable to share in that luxury of yours.

I need this. And I post it because people may need it too. But if it's a bad thing, I guess I'll keep this patch on my tree then.

-- 
Duy