git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC 2/4] Properly accept quoted space in filenames

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Nov 21, 2014, 09:42 UTC
Message-ID
<alpine.DEB.1.00.1411211041560.13845@s15462909.onlinehome-server.info>
In-Reply-To
<1416526682-6024-3-git-send-email-philipoakley@iee.org>
Hi Philip,
apart from adding dead code:
On Thu, 20 Nov 2014, Philip Oakley wrote:
Show 12 quoted lines
> diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl
> index 9144ea7..8e41808 100755
> --- a/contrib/buildsystems/engine.pl
> +++ b/contrib/buildsystems/engine.pl
> @@ -243,7 +244,8 @@ sub removeDuplicates
>  sub handleCompileLine
>  {
>      my ($line, $lineno) = @_;
> -    my @parts = split(' ', $line);
> +    # my @parts = split(' ', $line);
> +    my @parts = quotewords('\s+', 0, $line);
>      my $sourcefile;
(i.e. the commented-out line) it looks good to me.

Ciao, Johannes

Previous: Philip OakleyNext: Junio C Hamano
Message 6 of 19 in “[RFC 0/4] Fix the Visual Studio 2008 .sln generator”
  1. Philip OakleyNov 20, 2014
  2. 1/4 Fix i18n -o option in msvc engine.plPhilip Oakley, Nov 20, 2014
  3. Johannes SchindelinNov 21, 2014
  4. Philip OakleyNov 21, 2014
  5. 2/4 Properly accept quoted space in filenamesPhilip Oakley, Nov 20, 2014
  6. Johannes SchindelinNov 21, 2014
  7. Junio C HamanoNov 21, 2014
  8. Philip OakleyNov 21, 2014
  9. Junio C HamanoNov 21, 2014
  10. 3/4 engine.pl: split the .o and .obj processingPhilip Oakley, Nov 20, 2014
  11. Johannes SchindelinNov 21, 2014
  12. Philip OakleyNov 21, 2014
  13. Johannes SchindelinNov 23, 2014
  14. Philip OakleyNov 23, 2014
  15. 4/4 Improve layout and reference msvc-build scriptPhilip Oakley, Nov 20, 2014
  16. Johannes SchindelinNov 21, 2014
  17. Philip OakleyNov 21, 2014
  18. Johannes SchindelinNov 21, 2014
  19. Philip OakleyNov 21, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.