Re: [RFC 3/4] engine.pl: split the .o and .obj processing

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 23, 2014, 15:28 UTC
Message-ID: <alpine.DEB.1.00.1411231624230.13845@s15462909.onlinehome-server.info>
In-Reply-To: <622F65684C63407184D58ED19385AFD4@PhilipOakley>

Hi,

On Fri, 21 Nov 2014, Philip Oakley wrote:

Show 22 quoted lines

> From: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
>
> > On Thu, 20 Nov 2014, Philip Oakley wrote:
> >
> > > @@ -343,8 +346,10 @@ sub handleLinkLine
> > >          } elsif ($part =~ /\.(a|lib)$/) {
> > >              $part =~ s/\.a$/.lib/;
> > >              push(@libs, $part);
> > > -        } elsif ($part =~ /\.(o|obj)$/) {
> > > +        } elsif ($part =~ /\.o$/) { # was '/\.(o|obj)$'
> > >              push(@objfiles, $part);
> > > +        } elsif ($part =~ /\.obj$/) { # was '/\.(o|obj)$'
> > > +            # push(@objfiles, $part); # do nothing
> >
> > How about the following instead?
> >
> > + } elsif ($part eq 'invalidcontinue.obj') {
> > + # ignore
> >  } elsif ($part =~ /\.(o|obj)$/) {
> 
> Looks good, I'll use that (after deciding whether .obj files should be
> expected in a 'make' output anyway)

My idea to hardcode invalidcontinue.obj was that I'd rather see a failure if an unexpected .obj is seen there. But I realize that my suggested change does not exactly accomplish that.

Ciao, Johannes