From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 21 Nov 2014 09:42:41 GMT
Subject: Re: [RFC 2/4] Properly accept quoted space in filenames
Message-ID: <alpine.DEB.1.00.1411211041560.13845@s15462909.onlinehome-server.info>
In-Reply-To: <1416526682-6024-3-git-send-email-philipoakley@iee.org>

Hi Philip,

apart from adding dead code:

On Thu, 20 Nov 2014, Philip Oakley wrote:

> diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl
> index 9144ea7..8e41808 100755
> --- a/contrib/buildsystems/engine.pl
> +++ b/contrib/buildsystems/engine.pl
> @@ -243,7 +244,8 @@ sub removeDuplicates
>  sub handleCompileLine
>  {
>      my ($line, $lineno) = @_;
> -    my @parts = split(' ', $line);
> +    # my @parts = split(' ', $line);
> +    my @parts = quotewords('\s+', 0, $line);
>      my $sourcefile;

(i.e. the commented-out line) it looks good to me.

Ciao,
Johannes