git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC 0/4] Fix the Visual Studio 2008 .sln generator

From
Philip Oakley <philipoakley@iee.org>
Date
Nov 21, 2014, 19:57 UTC
Message-ID
<7E90FA1615514FA1B47B268DCBCA9534@PhilipOakley>
In-Reply-To
<alpine.DEB.1.00.1411211032060.13845@s15462909.onlinehome-server.info>
From: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Show 7 quoted lines
> Hi Philip,
>
> On Thu, 20 Nov 2014, Philip Oakley wrote:
>
>> Are the patches going in the right direction?
>
> Yes.
Magic. Glad of the confirmation
>
> A couple of general comments:
>
> - please do not comment out code. Just remove it.
It's my debugging style until I get it working ;-0
>
> - the first three commit messages look funny, being indented by 4
>  spaces... unintentional?

I think that was from one of the tools I was using at the time. They'll be tidied and reflowed for the final version(s).

Show 6 quoted lines
>
>> Is the processing of the .obj file in engine.pl sensible?
>
> Yes, but instead of adding dead code, it would be better to use the
> comment "# ignore". I would also strongly suggest to hard-code the
> complete file name instead of just the extension.
True, I realised that after posting (isnt it always the way).
> We know exactly which
> file name we want to ignore, and if there should be another .obj file
> eventually, it would be wrong to ignore it, too.

My concern was more about why a 'make' would produce .obj files (rather than .o files) in the first place. As I understand it we should never see .obj files generated from make with the exception of these ones that are library files implicitly known to MSVC - any thoughts?

Show 12 quoted lines
>
>> and the extra care with s/\.o$/.c/ avoiding s/obj/cbj/.
>
> Technically, you need to use a group \($\|[ \t]\), but I think that 
> that
> would be overkill.
>
>> Does it affect the Qmake capability? (I've no idea)
>
> Frankly, neither do I ;-) But since you touched only engine.pl, I 
> would
> expect Qmake not to be affected at all, right?

As I understood the call sequence merry go round, the engine can pull in either function depending on command line options, hence the open question. But like you say, why expect it to be affected, and no-one has mentioned on list for years;-)

>
>> Is the quoting of filenames correct? (my perl foo is cargo cult!)
>
> IANAPME (I am not a Perl Monk either), but it looks good to me.
OK.
Show 13 quoted lines
>
>> I've also updated the vcbuild/README to mention Msysgit (which
>> will be replaced soon by the newer/better Git-for-windows/SDK
>> (https://github.com/git-for-windows/sdk), but the benefits still
>> apply.
>
> The path you used is /msysgit/bin/msvc-build, but the real path would 
> be
> /bin/msvc-build.
>
>> Obviously, the patches will need squashing together,
>
> To the contrary, I like the current separation of concerns.

At the moment the first patch doesn't fully cure the .sln build, but there's no test anyway so bisecting would be problematic.

I'm happy to keep them small separate and clean ;-)
Show 8 quoted lines
>
> Ciao,
> Johannes
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Previous: Johannes Schindelin
Message 19 of 19 in “[RFC 0/4] Fix the Visual Studio 2008 .sln generator”
  1. Philip OakleyNov 20, 2014
  2. 1/4 Fix i18n -o option in msvc engine.plPhilip Oakley, Nov 20, 2014
  3. Johannes SchindelinNov 21, 2014
  4. Philip OakleyNov 21, 2014
  5. 2/4 Properly accept quoted space in filenamesPhilip Oakley, Nov 20, 2014
  6. Johannes SchindelinNov 21, 2014
  7. Junio C HamanoNov 21, 2014
  8. Philip OakleyNov 21, 2014
  9. Junio C HamanoNov 21, 2014
  10. 3/4 engine.pl: split the .o and .obj processingPhilip Oakley, Nov 20, 2014
  11. Johannes SchindelinNov 21, 2014
  12. Philip OakleyNov 21, 2014
  13. Johannes SchindelinNov 23, 2014
  14. Philip OakleyNov 23, 2014
  15. 4/4 Improve layout and reference msvc-build scriptPhilip Oakley, Nov 20, 2014
  16. Johannes SchindelinNov 21, 2014
  17. Philip OakleyNov 21, 2014
  18. Johannes SchindelinNov 21, 2014
  19. Philip OakleyNov 21, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.