git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC 1/4] Fix i18n -o option in msvc engine.pl

From
Philip Oakley <philipoakley@iee.org>
Date
Nov 20, 2014, 23:37 UTC
Message-ID
<1416526682-6024-2-git-send-email-philipoakley@iee.org>
In-Reply-To
<1416526682-6024-1-git-send-email-philipoakley@iee.org>
    The i18n 5e9637c6 introduced an extra '-o' option
    into the make file, which broke engine.pl code for
    extracting the git.sln for msvc gui-IDE.
    add tests for 'msgfmt' and its precursor 'mkdir'
    (in same vein as 74cf9bdda6).
    Signed-off-by: Philip Oakley <philipoakley@iee.org>
---
 contrib/buildsystems/engine.pl | 12 ++++++++++++
 1 file changed, 12 insertions(+)
diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl
index 23da787..9144ea7 100755
--- a/contrib/buildsystems/engine.pl
+++ b/contrib/buildsystems/engine.pl
@@ -140,6 +140,18 @@ sub parseMakeOutput
             next;
         }
 
+        if ($text =~ /^mkdir /) {
+            # options to the Portable Object translations in the line
+            # mkdir -p po/... && msgfmt ... (eg -o) may be mistaken for linker options
+            next;
+        }
+
+        if ($text =~ /^msgfmt /) {
+            # options to the Portable Object translations in the line
+            # mkdir -p po/... && msgfmt ... (eg -o) may be mistaken for linker options
+            next;
+        }
+
         if($text =~ / -c /) {
             # compilation
             handleCompileLine($text, $line);
-- 
1.9.4.msysgit.0

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Previous: Philip OakleyNext: Johannes Schindelin
Message 2 of 19 in “[RFC 0/4] Fix the Visual Studio 2008 .sln generator”
  1. Philip OakleyNov 20, 2014
  2. 1/4 Fix i18n -o option in msvc engine.plPhilip Oakley, Nov 20, 2014
  3. Johannes SchindelinNov 21, 2014
  4. Philip OakleyNov 21, 2014
  5. 2/4 Properly accept quoted space in filenamesPhilip Oakley, Nov 20, 2014
  6. Johannes SchindelinNov 21, 2014
  7. Junio C HamanoNov 21, 2014
  8. Philip OakleyNov 21, 2014
  9. Junio C HamanoNov 21, 2014
  10. 3/4 engine.pl: split the .o and .obj processingPhilip Oakley, Nov 20, 2014
  11. Johannes SchindelinNov 21, 2014
  12. Philip OakleyNov 21, 2014
  13. Johannes SchindelinNov 23, 2014
  14. Philip OakleyNov 23, 2014
  15. 4/4 Improve layout and reference msvc-build scriptPhilip Oakley, Nov 20, 2014
  16. Johannes SchindelinNov 21, 2014
  17. Philip OakleyNov 21, 2014
  18. Johannes SchindelinNov 21, 2014
  19. Philip OakleyNov 21, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.