git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] sha1-lookup: add new "sha1_pos" function to efficiently lookup sha1

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Apr 5, 2009, 13:11 UTC
Message-ID
<alpine.DEB.1.00.0904051510490.10279@pacific.mpi-cbg.de>
In-Reply-To
<20090404225926.a9ad50e0.chriscool@tuxfamily.org>
Hi,
On Sat, 4 Apr 2009, Christian Couder wrote:
Show 5 quoted lines
> This function has been copied from the "patch_pos" function in
> "patch-ids.c" but an additional parameter has been added.
> 
> The new parameter is a function pointer, that is used to access the
> sha1 of an element in the table.
Frankly, this is hard to follow.

It would have been easier if the first patch added that parameter, and the second patch just _moved_ the function.

Ciao, Dscho

Previous: Jay SoffianNext: Felipe Contreras
Message 19 of 20 in “sha1-lookup: add new "sha1_pos" function to efficiently lookup sha1”
  1. 1/4 sha1-lookup: add new "sha1_pos" function to efficiently lookup sha1Christian Couder, Apr 4, 2009
  2. Sverre RabbelierApr 5, 2009
  3. Jeff KingApr 5, 2009
  4. Sverre RabbelierApr 5, 2009
  5. Junio C HamanoApr 5, 2009
  6. Sverre RabbelierApr 5, 2009
  7. Jeff KingApr 5, 2009
  8. Sverre RabbelierApr 5, 2009
  9. Felipe ContrerasApr 5, 2009
  10. Reece DunnApr 5, 2009
  11. Junio C HamanoApr 5, 2009
  12. Jeff KingApr 5, 2009
  13. Sverre RabbelierApr 5, 2009
  14. Gnus content transfer encoding (was: [PATCH 1/4] sha1-lookup: add new "sha1_pos" function to efficiently lookup sha1)Teemu Likonen, Apr 5, 2009
  15. Junio C HamanoApr 6, 2009
  16. Reece DunnApr 5, 2009
  17. Jeff KingApr 5, 2009
  18. Jay SoffianApr 5, 2009
  19. Johannes SchindelinApr 5, 2009
  20. Felipe ContrerasApr 5, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.