Re: [PATCH 1/4] sha1-lookup: add new "sha1_pos" function to efficiently lookup sha1
- From
Sverre Rabbelier <srabbelier@gmail.com>
- Date
- Apr 5, 2009, 19:06 UTC
- Message-ID
- <fabb9a1e0904051206l11a629cald95a794815c2d76f@mail.gmail.com>
- In-Reply-To
- <7vvdpjrkp0.fsf@gitster.siamese.dyndns.org>
Heya,
On Sun, Apr 5, 2009 at 20:59, Junio C Hamano <gitster@pobox.com> wrote:
> It's not "going to be", but "has been so for the last two years since > 5d23e13".
Ah, I did not see that earlier, as I read and commented-on this patch before reading 3/4.
> It is an assert, and I think Peff's die("BUG: ...") would be a good idea.As long as the <something that makes sense to the user> does indeed make sense, right :).
-- Cheers, Sverre Rabbelier