Re: [PATCH 1/4] sha1-lookup: add new "sha1_pos" function to efficiently lookup sha1

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 5, 2009, 18:59 UTC
Message-ID: <7vvdpjrkp0.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <fabb9a1e0904050317o1399118erb15ddf86d0fe6c3c@mail.gmail.com>

Sverre Rabbelier <srabbelier@gmail.com> writes:

Show 6 quoted lines

> On Sat, Apr 4, 2009 at 22:59, Christian Couder <chriscool@tuxfamily.org> wrote:
>> +                               if (lo <= mi && mi < hi)
>> +                                       break;
>> +                               die("oops");
>
> That's going to be an official git error message? Why not make it "The

It's not "going to be", but "has been so for the last two years since 5d23e13".

It is an assert, and I think Peff's die("BUG: ...") would be a good idea.