git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] sha1-lookup: add new "sha1_pos" function to efficiently lookup sha1

From
Sverre Rabbelier <srabbelier@gmail.com>
Date
Apr 5, 2009, 20:05 UTC
Message-ID
<fabb9a1e0904051305m66b08c44y23129469198bfd0b@mail.gmail.com>
In-Reply-To
<20090405195908.GB4716@coredump.intra.peff.net>
Heya,
On Sun, Apr 5, 2009 at 21:59, Jeff King <peff@peff.net> wrote:
>  die("BUG: assertion failed in binary search")

Given that we now only have one binary search (which should be re-used everywhere), I think it's fair enough to describe it like that.

> However, if this "oops" has been there for 2 years and nobody has seen
> it, it's entirely possible that somebody actually got the binary search
> code right in the first place. ;)

Hehe, never underestimate the difficulty of writing a proper binary search! :P But I do agree two years of 'testing' is more than more binary searches get before being 'released' ;).

-- 
Cheers,

Sverre Rabbelier
Previous: Jeff KingNext: Felipe Contreras
Message 8 of 20 in “sha1-lookup: add new "sha1_pos" function to efficiently lookup sha1”
  1. 1/4 sha1-lookup: add new "sha1_pos" function to efficiently lookup sha1Christian Couder, Apr 4, 2009
  2. Sverre RabbelierApr 5, 2009
  3. Jeff KingApr 5, 2009
  4. Sverre RabbelierApr 5, 2009
  5. Junio C HamanoApr 5, 2009
  6. Sverre RabbelierApr 5, 2009
  7. Jeff KingApr 5, 2009
  8. Sverre RabbelierApr 5, 2009
  9. Felipe ContrerasApr 5, 2009
  10. Reece DunnApr 5, 2009
  11. Junio C HamanoApr 5, 2009
  12. Jeff KingApr 5, 2009
  13. Sverre RabbelierApr 5, 2009
  14. Gnus content transfer encoding (was: [PATCH 1/4] sha1-lookup: add new "sha1_pos" function to efficiently lookup sha1)Teemu Likonen, Apr 5, 2009
  15. Junio C HamanoApr 6, 2009
  16. Reece DunnApr 5, 2009
  17. Jeff KingApr 5, 2009
  18. Jay SoffianApr 5, 2009
  19. Johannes SchindelinApr 5, 2009
  20. Felipe ContrerasApr 5, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.