Re: [PATCH 4/4] Rename push.default to push.style

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 30, 2009, 08:23 UTC
Message-ID: <alpine.DEB.1.00.0903301021540.7534@intel-tinevez-2-302>
In-Reply-To: <20090330080115.GA19142@pvv.org>

Hi,

On Mon, 30 Mar 2009, Finn Arne Gangstad wrote:

Show 16 quoted lines

> On Sun, Mar 29, 2009 at 12:10:04AM +0100, Santi Béjar wrote:
> > push.default was too generic, and also didn't specify if it was about
> > remote, refspec, branches, behaviour...
> > [...]
> >  	"You can specify what action you want to take in this case, and",
> > -	"avoid seeing this message again, by configuring 'push.default' to:",
> > +	"avoid seeing this message again, by configuring 'push.style' to:",
> >  	"  'nothing'  : Do not push anything",
> >  	"  'matching' : Push all matching branches (default)",
> >  	"  'tracking' : Push the current branch to whatever it is tracking",
> > [...]
> 
> I don't think "push.style" is an improvement. "style" sounds like it 
> affects all pushes. This configuration variable says what push should do 
> when no refspec is given and none are configured, so the word "default" 
> should be in there at least. Maybe "defaultref" would have been better?

I'd prefer "push.defaultMode", but...

> Some people may have started setting push.default already, so changing 
> the name may cause additional grief.

... indeed, it is too late now.  The milk has boiled already.

Ciao, Dscho