git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] Rename push.default to push.style

From
Jeff King <peff@peff.net>
Date
Mar 30, 2009, 10:29 UTC
Message-ID
<20090330102739.GA5163@sigill.intra.peff.net>
In-Reply-To
<adf1fd3d0903300200v65393b1bif0050392aa44652e@mail.gmail.com>
On Mon, Mar 30, 2009 at 11:00:03AM +0200, Santi Béjar wrote:
Show 7 quoted lines
> >> This configuration variable says what push should do
> >> when no refspec is given and none are configured, so the word "default"
> >> should be in there at least. Maybe "defaultref" would have been better?
> 
> I don't see the point of the word default, a lot of configuration is
> to set the default value. Git has branch.name.remote, not
> branch.name.defaultremote, or user.email, not user.defaultemail,...

The usual case is two layers of options: command line and config options. Thus "git push <remote>" overrides "branch.*.remote".

But in this case there are actually _three_ layers: command line, branch.*.push, and now push.default. I think a name like "push.mode" doesn't make clear the fact that it will never be looked at if you have "branch.*.push" set up.

I think you have a point that "default" is vague, but "defaultMode" would be better than simply "mode".

-Peff
Previous: Santi BéjarNext: Santi Béjar
Message 12 of 13 in “push.default and branch.<name>.{remote,merge} changes”
  1. 0/4 push.default and branch.<name>.{remote,merge} changesSanti Béjar, Mar 28, 2009
  2. 1/4 Documentation: enhance branch.<name>.{remote,merge}Santi Béjar, Mar 28, 2009
  3. Jay SoffianMar 29, 2009
  4. Santi BéjarMar 29, 2009
  5. 2/4 Documentation: push.default applies to all remotesSanti Béjar, Mar 28, 2009
  6. 3/4 Documentation: branch.*.merge can also afect 'git-push'Santi Béjar, Mar 28, 2009
  7. 4/4 Rename push.default to push.styleSanti Béjar, Mar 28, 2009
  8. Finn Arne GangstadMar 30, 2009
  9. Johannes SchindelinMar 30, 2009
  10. Santi BéjarMar 30, 2009
  11. Santi BéjarMar 30, 2009
  12. Jeff KingMar 30, 2009
  13. Santi BéjarMar 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.