Re: [PATCH 4/4] Rename push.default to push.style
- From
- Santi Béjar <santi@agolina.net>
- Date
- Mar 30, 2009, 09:00 UTC
- Message-ID
- <adf1fd3d0903300200v65393b1bif0050392aa44652e@mail.gmail.com>
- In-Reply-To
- <alpine.DEB.1.00.0903301021540.7534@intel-tinevez-2-302>
2009/3/30 Johannes Schindelin <Johannes.Schindelin@gmx.de>:
Show 18 quoted lines
> Hi, > > On Mon, 30 Mar 2009, Finn Arne Gangstad wrote: > >> On Sun, Mar 29, 2009 at 12:10:04AM +0100, Santi Béjar wrote: >> > push.default was too generic, and also didn't specify if it was about >> > remote, refspec, branches, behaviour... >> > [...] >> > "You can specify what action you want to take in this case, and", >> > - "avoid seeing this message again, by configuring 'push.default' to:", >> > + "avoid seeing this message again, by configuring 'push.style' to:", >> > " 'nothing' : Do not push anything", >> > " 'matching' : Push all matching branches (default)", >> > " 'tracking' : Push the current branch to whatever it is tracking", >> > [...] >> >> I don't think "push.style" is an improvement. "style" sounds like it >> affects all pushes.
Not for me. I says the style of the push. But maybe push.mode could be better.
>> This configuration variable says what push should do >> when no refspec is given and none are configured, so the word "default" >> should be in there at least. Maybe "defaultref" would have been better?
I don't see the point of the word default, a lot of configuration is to set the default value. Git has branch.name.remote, not branch.name.defaultremote, or user.email, not user.defaultemail,...
Show 7 quoted lines
> > I'd prefer "push.defaultMode", but... > >> Some people may have started setting push.default already, so changing >> the name may cause additional grief. > > ... indeed, it is too late now. The milk has boiled already.
I have it configured, but I think we can fix these type of things while they are in 'next'.
Santi