Re: [PATCH 4/4] Rename push.default to push.style
- From
Finn Arne Gangstad <finnag@pvv.org>
- Date
- Mar 30, 2009, 08:01 UTC
- Message-ID
- <20090330080115.GA19142@pvv.org>
- In-Reply-To
- <1238281804-30290-5-git-send-email-santi@agolina.net>
On Sun, Mar 29, 2009 at 12:10:04AM +0100, Santi Béjar wrote:
Show 10 quoted lines
> push.default was too generic, and also didn't specify if it was about > remote, refspec, branches, behaviour... > [...] > "You can specify what action you want to take in this case, and", > - "avoid seeing this message again, by configuring 'push.default' to:", > + "avoid seeing this message again, by configuring 'push.style' to:", > " 'nothing' : Do not push anything", > " 'matching' : Push all matching branches (default)", > " 'tracking' : Push the current branch to whatever it is tracking", > [...]
I don't think "push.style" is an improvement. "style" sounds like it affects all pushes. This configuration variable says what push should do when no refspec is given and none are configured, so the word "default" should be in there at least. Maybe "defaultref" would have been better?
Some people may have started setting push.default already, so changing the name may cause additional grief.
- Finn Arne