Re: [PATCH 3/3] Valgrind support: check for more than just programming errors
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 26, 2009, 00:43 UTC
- Message-ID
- <alpine.DEB.1.00.0901260142100.14855@racer>
- In-Reply-To
- <20090125234249.GE19099@coredump.intra.peff.net>
Hi,
On Sun, 25 Jan 2009, Jeff King wrote:
Show 9 quoted lines
> On Mon, Jan 26, 2009 at 12:20:21AM +0100, Johannes Schindelin wrote: > > > While it is not strictly necessary to look through the whole PATH to > > find git binaries to override, it is in line with running an expensive > > test (which valgrind is) to make extra sure that no binary is tested > > that actually comes from the git.git checkout. > > Should this be "...no binary is tested that _doesn't_ actually come from > the git.git checkout"?
Yep, that was half the change to "that only binaries are tested...".
Thanks, Dscho