Re: valgrind patches, was Re: What's cooking in git.git (Jan 2009, #04; Mon, 19)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 22, 2009, 00:42 UTC
- Message-ID
- <7vr62wb28h.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <alpine.DEB.1.00.0901212259420.3586@pacific.mpi-cbg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Fact is: every test script will check $GIT_VALGRIND/bin/ for > up-to-dateness first. Before running any Git command.
Hmm, is that a good thing in general? Can't makefile rules be arranged in such a way that one "valgrind-prep" target runs before all the potentially parallel executions of actual tests begin?
Independent from the above, I suspect that some of the existing tests cannot run in parallel; I haven't really looked at any of them, but a server-ish tests to open a local port and test interaction with client obviously need to either use different ports or serialize. Perhaps we need a way to mark some tests that cannot be run in parallel even under "make -j"?