Re: valgrind patches, was Re: What's cooking in git.git (Jan 2009, #04; Mon, 19)
- From
Jeff King <peff@peff.net>
- Date
- Jan 21, 2009, 23:57 UTC
- Message-ID
- <20090121235757.GA9668@sigill.intra.peff.net>
- In-Reply-To
- <alpine.DEB.1.00.0901212259420.3586@pacific.mpi-cbg.de>
On Wed, Jan 21, 2009 at 11:17:35PM +0100, Johannes Schindelin wrote:
> Phew. A lot of time, a lot of braincycles, and a lot of keystrokes wasted > on that subject, don't you think?
Yes, especially considering my other email that said I had dropped the subject. ;P
But thank you for discussing it. There is still some part of me that says "if you have no races, you don't have to worry about analyzing them." But I think your analysis is correct, and I am willing to let it go in the name of practicality.
As for braincycles, I don't think they were necessarily wasted. The point of review is to double-check, and the discussion is how we resolve (even if we resolve that it is OK as-is). Of course there is such a thing as useless, annoying pedantry, but I hope this didn't count... :)
-Peff