Re: What's cooking in git.git (Jan 2009, #04; Mon, 19)

From: Jeff King <peff@peff.net>
Date: Jan 20, 2009, 04:40 UTC
Message-ID: <20090120044021.GE30714@sigill.intra.peff.net>
In-Reply-To: <7vbpu3r745.fsf@gitster.siamese.dyndns.org>

On Mon, Jan 19, 2009 at 01:13:30AM -0800, Junio C Hamano wrote:

Show 6 quoted lines

> * jk/signal-cleanup (Sun Jan 11 06:36:49 2009 -0500) 3 commits
>  - pager: do wait_for_pager on signal death
>  - refactor signal handling for cleanup functions
>  - chain kill signals for cleanup functions
> 
> Sorry, I lost track.  What is the status of this one?

I need to clean up and re-send. The three improvements needed are:

  - there is a related Windows cleanup from JSixt, which I will send
    when I re-post

  - the test needs a few tweaks to be portable to Windows

  - Some of the signal handlers should be guarded from inserting
    themselves multiple times. I don't think any are dangerous to run
    twice (they generally traverse a list, cleaning up files, and then
    remove the list elements), but I'm not sure that you can't get some
    stupid behavior, like inserting one handler per diff'd file, which
    will unnecessarily allocate memory.

This series fixes pager handling for interrupted git programs. There is also a related fix that needs to be done for forked git programs. I posted a "how about this" patch to use run_command for external git programs, but it has some serious problems ("git bogus" no longer reports an error!).

I have unfortunately not had very much git time lately, but I'll try to come up with something for both cases this week.

-Peff