Re: [WIP Patch 02/12] Some cleanup in get_refs_via_curl()

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 18, 2009, 19:11 UTC
Message-ID: <alpine.DEB.1.00.0901182010380.3586@pacific.mpi-cbg.de>
In-Reply-To: <alpine.DEB.1.00.0901182005230.3586@pacific.mpi-cbg.de>

Hi,

On Sun, 18 Jan 2009, Johannes Schindelin wrote:

Show 17 quoted lines

> On Sun, 18 Jan 2009, Mike Hommey wrote:
> 
> > diff --git a/transport.c b/transport.c
> > index 56831c5..6919ff1 100644
> > --- a/transport.c
> > +++ b/transport.c
> > @@ -508,6 +508,8 @@ static struct ref *get_refs_via_curl(struct transport *transport)
> >  		free(ref);
> >  	}
> >  
> > +	http_cleanup();
> > +	free(refs_url);
> >  	return refs;
> >  }
> 
> You cannot http_cleanup() here, as http-push calls that function, but 
> continues to want to use curl.

Worse, a http clone will hit the same issue.

Ciao, Dscho

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.