git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http-push: fix off-by-path_len

From
Mike Hommey <mh@glandium.org>
Date
Jan 18, 2009, 07:49 UTC
Message-ID
<20090118074911.GB30228@glandium.org>
In-Reply-To
<alpine.DEB.1.00.0901171632330.3586@pacific.mpi-cbg.de>
On Sat, Jan 17, 2009 at 04:36:26PM +0100, Johannes Schindelin wrote:
Show 17 quoted lines
> 
> When getting the result of remote_ls(), we were advancing the variable
> "path" to the relative path inside the repository.
> 
> However, then we went on to malloc a bogus amount of memory: we were
> subtracting the prefix length _again_, quite possibly getting something
> negative, which xmalloc() interprets as really, really much.
> 
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> 
> 	Note that the push in t5540 is still broken, as http-push does
> 	not handle packed-refs (when looking what branches are on the 
> 	remote side).
> 
> 	It should not even try to access the directory structure under
> 	refs/ to begin with, but read info/refs instead.

It would actually need to do both, because nothing guarantees info/refs is up-to-date.

> 	However, that is just one example of the ugliness that is 
> 	http-push.c; it also seems to be a perfect example of a copy-pasting 
> 	hell; just look at the output of "git grep
> 	curl_easy_setopt http-push.c".
Likewise for http.c.
> 	There _has_ to be lot of room for improvement.

And I realize I have had a partial improvement on that sitting on my harddrive, without me having time (nor motivation) to go further.

Maybe it's time I let it go and post the work in progress for someone else to take over.

Mike
Previous: Johannes SchindelinNext: Mike Hommey
Message 4 of 33 in “http-push: fix off-by-path_len”
  1. http-push: fix off-by-path_lenJohannes Schindelin, Jan 17, 2009
  2. Where's Nick?, was Re: [PATCH] http-push: fix off-by-path_lenJohannes Schindelin, Jan 17, 2009
  3. t5540: clarify that http-push does not handle packed-refs on the remoteJohannes Schindelin, Jan 17, 2009
  4. Mike HommeyJan 18, 2009
  5. 00/12 Refactoring the http APIMike Hommey, Jan 18, 2009
  6. 01/12 Don't expect verify_pack() callers to set pack_sizeMike Hommey, Jan 18, 2009
  7. 02/12 Some cleanup in get_refs_via_curl()Mike Hommey, Jan 18, 2009
  8. 03/12 Two new functions for the http APIMike Hommey, Jan 18, 2009
  9. 04/12 Use the new http API in http_fetch_ref()Mike Hommey, Jan 18, 2009
  10. 05/12 Use the new http API in get_refs_via_curl()Mike Hommey, Jan 18, 2009
  11. 06/12 Use the new http API in http-walker.c:fetch_indices()Mike Hommey, Jan 18, 2009
  12. 07/12 Use the new http API in http-push.c:fetch_indices()Mike Hommey, Jan 18, 2009
  13. 08/12 Use the new http API in update_remote_info_refs()Mike Hommey, Jan 18, 2009
  14. 09/12 Use the new http API in fetch_symref()Mike Hommey, Jan 18, 2009
  15. 10/12 Use the new http API in http-walker.c:fetch_index()Mike Hommey, Jan 18, 2009
  16. 11/12 Use the new http API in http-push.c:fetch_index()Mike Hommey, Jan 18, 2009
  17. 12/12 Use the new http API in http-walker.c:fetch_pack()Mike Hommey, Jan 18, 2009
  18. Johannes SchindelinJan 18, 2009
  19. Mike HommeyJan 18, 2009
  20. Johannes SchindelinJan 18, 2009
  21. Johannes SchindelinJan 18, 2009
  22. Johannes SchindelinJan 18, 2009
  23. Mike HommeyJan 18, 2009
  24. Johannes SchindelinJan 18, 2009
  25. Johannes SchindelinJan 18, 2009
  26. Johannes SchindelinJan 18, 2009
  27. Mike HommeyJan 18, 2009
  28. Johannes SchindelinJan 18, 2009
  29. Mike HommeyJan 18, 2009
  30. Johannes SchindelinJan 18, 2009
  31. Junio C HamanoJan 18, 2009
  32. Mike HommeyJan 18, 2009
  33. Boyd Stephen Smith Jr.Jan 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.