Re: [WIP Patch 02/12] Some cleanup in get_refs_via_curl()
On Sun, Jan 18, 2009 at 08:06:17PM +0100, Johannes Schindelin wrote:
Show 19 quoted lines
> Hi,
>
> On Sun, 18 Jan 2009, Mike Hommey wrote:
>
> > diff --git a/transport.c b/transport.c
> > index 56831c5..6919ff1 100644
> > --- a/transport.c
> > +++ b/transport.c
> > @@ -508,6 +508,8 @@ static struct ref *get_refs_via_curl(struct transport *transport)
> > free(ref);
> > }
> >
> > + http_cleanup();
> > + free(refs_url);
> > return refs;
> > }
>
> You cannot http_cleanup() here, as http-push calls that function, but
> continues to want to use curl.
Are you really sure? It doesn't seem so, to me.
Mike