Re: [WIP Patch 00/12] Refactoring the http API

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 18, 2009, 08:30 UTC
Message-ID: <7v8wp9yq23.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1232265877-3649-1-git-send-email-mh@glandium.org>

Mike Hommey <mh@glandium.org> writes:

Show 8 quoted lines

> As it is work in progress, some error handling might have regressions, but
> the original error handling is not necessarily much better.
>
> Also note I only rebased my one-year-old work on current master, and haven't
> actually tested it, though, as the code hasn't changed much, I guess it
> should be fine.
> ...
>  6 files changed, 162 insertions(+), 304 deletions(-)

Thanks.

This looks like a very nice code reduction, and the first few patches looked obviously correct, too ;-)

But I am puzzled by what you mean by "haven't actually tested it". Do you mean you do not use http transport very much yourself, or even when you do you do not use a version of git with these patches applied?