git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [WIP Patch 00/12] Refactoring the http API

From
Mike Hommey <mh@glandium.org>
Date
Jan 18, 2009, 09:12 UTC
Message-ID
<20090118091219.GA6505@glandium.org>
In-Reply-To
<7v8wp9yq23.fsf@gitster.siamese.dyndns.org>
On Sun, Jan 18, 2009 at 12:30:12AM -0800, Junio C Hamano wrote:
Show 19 quoted lines
> Mike Hommey <mh@glandium.org> writes:
> 
> > As it is work in progress, some error handling might have regressions, but
> > the original error handling is not necessarily much better.
> >
> > Also note I only rebased my one-year-old work on current master, and haven't
> > actually tested it, though, as the code hasn't changed much, I guess it
> > should be fine.
> > ...
> >  6 files changed, 162 insertions(+), 304 deletions(-)
> 
> Thanks.
> 
> This looks like a very nice code reduction, and the first few patches
> looked obviously correct, too ;-)
> 
> But I am puzzled by what you mean by "haven't actually tested it".  Do you
> mean you do not use http transport very much yourself, or even when you do
> you do not use a version of git with these patches applied?

I mean I haven't tested the rebased version. The original version was tested extensively a year ago. I don't use http transport that much now.

Mike
Previous: Junio C HamanoNext: Boyd Stephen Smith Jr.
Message 32 of 33 in “http-push: fix off-by-path_len”
  1. http-push: fix off-by-path_lenJohannes Schindelin, Jan 17, 2009
  2. Where's Nick?, was Re: [PATCH] http-push: fix off-by-path_lenJohannes Schindelin, Jan 17, 2009
  3. t5540: clarify that http-push does not handle packed-refs on the remoteJohannes Schindelin, Jan 17, 2009
  4. Mike HommeyJan 18, 2009
  5. 00/12 Refactoring the http APIMike Hommey, Jan 18, 2009
  6. 01/12 Don't expect verify_pack() callers to set pack_sizeMike Hommey, Jan 18, 2009
  7. 02/12 Some cleanup in get_refs_via_curl()Mike Hommey, Jan 18, 2009
  8. 03/12 Two new functions for the http APIMike Hommey, Jan 18, 2009
  9. 04/12 Use the new http API in http_fetch_ref()Mike Hommey, Jan 18, 2009
  10. 05/12 Use the new http API in get_refs_via_curl()Mike Hommey, Jan 18, 2009
  11. 06/12 Use the new http API in http-walker.c:fetch_indices()Mike Hommey, Jan 18, 2009
  12. 07/12 Use the new http API in http-push.c:fetch_indices()Mike Hommey, Jan 18, 2009
  13. 08/12 Use the new http API in update_remote_info_refs()Mike Hommey, Jan 18, 2009
  14. 09/12 Use the new http API in fetch_symref()Mike Hommey, Jan 18, 2009
  15. 10/12 Use the new http API in http-walker.c:fetch_index()Mike Hommey, Jan 18, 2009
  16. 11/12 Use the new http API in http-push.c:fetch_index()Mike Hommey, Jan 18, 2009
  17. 12/12 Use the new http API in http-walker.c:fetch_pack()Mike Hommey, Jan 18, 2009
  18. Johannes SchindelinJan 18, 2009
  19. Mike HommeyJan 18, 2009
  20. Johannes SchindelinJan 18, 2009
  21. Johannes SchindelinJan 18, 2009
  22. Johannes SchindelinJan 18, 2009
  23. Mike HommeyJan 18, 2009
  24. Johannes SchindelinJan 18, 2009
  25. Johannes SchindelinJan 18, 2009
  26. Johannes SchindelinJan 18, 2009
  27. Mike HommeyJan 18, 2009
  28. Johannes SchindelinJan 18, 2009
  29. Mike HommeyJan 18, 2009
  30. Johannes SchindelinJan 18, 2009
  31. Junio C HamanoJan 18, 2009
  32. Mike HommeyJan 18, 2009
  33. Boyd Stephen Smith Jr.Jan 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.