Re: [WIP Patch 00/12] Refactoring the http API
- From
Mike Hommey <mh@glandium.org>
- Date
- Jan 18, 2009, 09:12 UTC
- Message-ID
- <20090118091219.GA6505@glandium.org>
- In-Reply-To
- <7v8wp9yq23.fsf@gitster.siamese.dyndns.org>
On Sun, Jan 18, 2009 at 12:30:12AM -0800, Junio C Hamano wrote:
Show 19 quoted lines
> Mike Hommey <mh@glandium.org> writes: > > > As it is work in progress, some error handling might have regressions, but > > the original error handling is not necessarily much better. > > > > Also note I only rebased my one-year-old work on current master, and haven't > > actually tested it, though, as the code hasn't changed much, I guess it > > should be fine. > > ... > > 6 files changed, 162 insertions(+), 304 deletions(-) > > Thanks. > > This looks like a very nice code reduction, and the first few patches > looked obviously correct, too ;-) > > But I am puzzled by what you mean by "haven't actually tested it". Do you > mean you do not use http transport very much yourself, or even when you do > you do not use a version of git with these patches applied?
I mean I haven't tested the rebased version. The original version was tested extensively a year ago. I don't use http transport that much now.
Mike