Re: [PATCH] Cleanup of unused symcache variable inside diff-lib.c
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 11, 2009, 20:17 UTC
- Message-ID
- <alpine.DEB.1.00.0901112112540.3586@pacific.mpi-cbg.de>
- In-Reply-To
- <86eiz98v0s.fsf@broadpark.no>
Hi,
On Sun, 11 Jan 2009, Kjetil Barvik wrote:
> git format-patch
Necessary.
> --stat
Not necessary.
> --patch-with-raw
As I showed you, also not necessary.
> -1
Necessary.
> --signoff
If you had signed off on your commits already, not necessary. (FWIW I keep a sign off as a marker that I actually think this is good to be submitted, or at least close.)
> -M -C
Usualy not necessary, unless you rename some file, or introduce a huge code duplication.
> --summary
Dunno. I think it's not really necessary, you see that from the diff.
> --full-index
I find it makes the patch hard to read, as the index line will always wrap. And it's not necessary, as it is so highly unlikely that the hash is unique in your repository, but not mine.
> --subject-prefix="PATCH"
Not necessary.
> --output-directory ../diff_lib_c_symcache_cleanup_v1/
If you insist...
Sure, you can make it complicated, but I usually prefer something like
$ git format-patch -3 --cover-letter
Nice 'n easy.
Ciao, Dscho