Re: [PATCH] Cleanup of unused symcache variable inside diff-lib.c

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 11, 2009, 19:46 UTC
Message-ID: <alpine.DEB.1.00.0901112044230.3586@pacific.mpi-cbg.de>
In-Reply-To: <86iqol8wql.fsf@broadpark.no>

Hi,

On Sun, 11 Jan 2009, Kjetil Barvik wrote:

Show 13 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Sun, 11 Jan 2009, Kjetil Barvik wrote:
> >
> >> :100644 100644 ae96c64... e6d1d2b... M	diff-lib.c
>
> [...]
>
> kjetil@localhost ~/git2 $ git clone -q git://git.kernel.org/pub/scm/git/git.git
> kjetil@localhost ~/git2 $ cd git/
> kjetil@localhost ~/git2/git $ git show e6d1d2b34147a13aadb5019e0c8336ef5f56ee39
>      outputs => 
>             fatal: bad object e6d1d2b34147a13aadb5019e0c8336ef5f56ee39

Your patch has not been applied yet. So no surprise there: your version of diff-lib.c is not there. You'll have more luck with ae96c64, I guess...

My question was more: why do you do additional work and put a git diff --raw between the commit message and the diffstat when that information is in the patch already?

Ciao, Dscho