Re: [PATCH] Cleanup of unused symcache variable inside diff-lib.c

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 11, 2009, 22:23 UTC
Message-ID: <7vab9xpjmp.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <86eiz98v0s.fsf@broadpark.no>

Kjetil Barvik <barvik@broadpark.no> writes:

Show 12 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> <snipp>
>> My question was more: why do you do additional work and put a git diff 
>> --raw between the commit message and the diffstat when that information is 
>> in the patch already?
>
>  Ok, I see.  I (re)used the 'git format-patch' command from previous
>  run, and this time it was (without the line-breaks):
>
>     git format-patch  --stat  --patch-with-raw -1 --signoff -M -C
>        --summary --full-index --subject-prefix="PATCH"
>        --output-directory ../diff_lib_c_symcache_cleanup_v1/

Please drop --patch-with-raw and --full-index.  They are distracting.

I do not think using --subject-prefix=PATCH to repeat what is default adds any value either.