git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Cleanup of unused symcache variable inside diff-lib.c

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 12, 2009, 05:39 UTC
Message-ID
<7v4p05krqe.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1231699002-5316-1-git-send-email-barvik@broadpark.no>
Kjetil Barvik <barvik@broadpark.no> writes:
Show 12 quoted lines
> diff --git a/diff-lib.c b/diff-lib.c
> index ae96c64ca209f4df9008198e8a04b160bed618c7..e6d1d2b34147a13aadb5019e0c8336ef5f56ee39 100644
> --- a/diff-lib.c
> +++ b/diff-lib.c
> ...
> @@ -344,8 +334,7 @@ static void do_oneway_diff(struct unpack_trees_options *o,
>  	struct cache_entry *idx,
>  	struct cache_entry *tree)
>  {
> -	struct oneway_unpack_data *cbdata = o->unpack_data;
> -	struct rev_info *revs = cbdata->revs;
> +	struct rev_info *revs = o->unpack_data;;
Thanks; I'll clean-up the extra semicolon and apply.
Previous: Junio C Hamano
Message 10 of 10 in “Cleanup of unused symcache variable inside diff-lib.c”
  1. Cleanup of unused symcache variable inside diff-lib.cKjetil Barvik, Jan 11, 2009
  2. Johannes SchindelinJan 11, 2009
  3. Kjetil BarvikJan 11, 2009
  4. Johannes SchindelinJan 11, 2009
  5. Kjetil BarvikJan 11, 2009
  6. Johannes SchindelinJan 11, 2009
  7. Kjetil BarvikJan 11, 2009
  8. Junio C HamanoJan 11, 2009
  9. Junio C HamanoJan 11, 2009
  10. Junio C HamanoJan 12, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.