Re: [PATCH] Cleanup of unused symcache variable inside diff-lib.c

From: Kjetil Barvik <barvik@broadpark.no>
Date: Jan 11, 2009, 20:09 UTC
Message-ID: <86eiz98v0s.fsf@broadpark.no>
In-Reply-To: <alpine.DEB.1.00.0901112044230.3586@pacific.mpi-cbg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: <snipp>

> My question was more: why do you do additional work and put a git diff 
> --raw between the commit message and the diffstat when that information is 
> in the patch already?

 Ok, I see.  I (re)used the 'git format-patch' command from previous
 run, and this time it was (without the line-breaks):

    git format-patch  --stat  --patch-with-raw -1 --signoff -M -C
       --summary --full-index --subject-prefix="PATCH"
       --output-directory ../diff_lib_c_symcache_cleanup_v1/

  Regarding the '--summary' I think it is a nice thing to do (so I try
  to always use it), and the '--full-index' is such that the git software
  have a less chance of producing a collision.

  -- kjetil