git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] t6030 (bisect): work around Mac OS X "ls"

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 24, 2008, 17:44 UTC
Message-ID
<alpine.DEB.1.00.0807241842030.8986@racer>
In-Reply-To
<20080724165434.GA26660@glandium.org>
Hi,
On Thu, 24 Jul 2008, Mike Hommey wrote:
Show 13 quoted lines
> On Thu, Jul 24, 2008 at 02:43:51AM -0500, Jonathan Nieder wrote:
>
> > Mike Hommey wrote:
> > 
> > > On Thu, Jul 24, 2008 at 07:57:26AM +0200, Christian Couder wrote:
> > >
> > >> +	test -z "$(ls .git/BISECT_*)" &&
> > > 
> > > That is still a useless use of ls ;)
> > 
> > It is much better than what I wrote, at least.
> 
> But could also be written with echo instead of ls.
Sure, but then it looks uglier:
		test ".git/BISECT_*" = "$(echo .git/BISECT_*)" &&
and it is much easier to hide a typo there.

And now the big question: is it performance critical? Or is obvious correctness the highest goal here?

Hth, Dscho

Previous: Mike HommeyNext: Jonathan Nieder
Message 6 of 12 in “t6030 (bisect): work around Mac OS X "ls"”
  1. t6030 (bisect): work around Mac OS X "ls"Jonathan Nieder, Jul 24, 2008
  2. Christian CouderJul 24, 2008
  3. Mike HommeyJul 24, 2008
  4. t6030 (bisect): work around Mac OS X "ls"Jonathan Nieder, Jul 24, 2008
  5. Mike HommeyJul 24, 2008
  6. Johannes SchindelinJul 24, 2008
  7. t6030 (bisect): work around Mac OS X "ls"Jonathan Nieder, Jul 24, 2008
  8. Jonathan NiederJul 24, 2008
  9. Christian CouderJul 27, 2008
  10. Christian CouderJul 27, 2008
  11. t6030 (bisect): work around Mac OS X "ls"Jonathan Nieder, Jul 27, 2008
  12. Christian CouderJul 27, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.